Fix a bug where tags were being lost when creating buckets in us-east-1#6492
Merged
Fix a bug where tags were being lost when creating buckets in us-east-1#6492
Conversation
|
davidh44
approved these changes
Oct 21, 2025
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags are being lost with create bucket requests for us-east-1 when location constraint is not manually specified.
Motivation and Context
Tags were lost because the
CreateBucketInterceptorsets the whole body of the request tonullforus-east-1region when location constraint is not specified.CreateBucketInterceptorsets it to null sinceus-east-1requires no location constraint.Modifications
Do not set full body to null of Tags are specified, instead copy the tags and only set
locationConstraintto null.Testing
Added unit test
Types of changes